fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS for dynamicScaling #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r dynamicScaling Signed-off-by: Ishita Sequeira <[email protected]>
Signed-off-by: Ishita Sequeira <[email protected]>
ishitasequeira
added a commit
to ishitasequeira/argocd-operator
that referenced
this pull request
Oct 24, 2024
…r dynamicScaling (argoproj-labs#1574) * fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS for dynamicScaling Signed-off-by: Ishita Sequeira <[email protected]> * fix lint issues Signed-off-by: Ishita Sequeira <[email protected]> --------- Signed-off-by: Ishita Sequeira <[email protected]>
2 tasks
ishitasequeira
added a commit
to ishitasequeira/argocd-operator
that referenced
this pull request
Oct 24, 2024
…r dynamicScaling (argoproj-labs#1574) * fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS for dynamicScaling Signed-off-by: Ishita Sequeira <[email protected]> * fix lint issues Signed-off-by: Ishita Sequeira <[email protected]> --------- Signed-off-by: Ishita Sequeira <[email protected]>
2 tasks
ishitasequeira
added a commit
to ishitasequeira/argocd-operator
that referenced
this pull request
Oct 24, 2024
…r dynamicScaling (argoproj-labs#1574) * fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS for dynamicScaling Signed-off-by: Ishita Sequeira <[email protected]> * fix lint issues Signed-off-by: Ishita Sequeira <[email protected]> --------- Signed-off-by: Ishita Sequeira <[email protected]>
2 tasks
anandf
pushed a commit
that referenced
this pull request
Oct 25, 2024
…r dynamicScaling (#1574) (#1576) * fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS for dynamicScaling * fix lint issues --------- Signed-off-by: Ishita Sequeira <[email protected]>
anandf
pushed a commit
that referenced
this pull request
Oct 25, 2024
…r dynamicScaling (#1574) (#1575) * fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS for dynamicScaling * fix lint issues --------- Signed-off-by: Ishita Sequeira <[email protected]>
anandf
pushed a commit
that referenced
this pull request
Oct 25, 2024
…r dynamicScaling (#1574) (#1577) * fix the setting of environment variable ARGOCD_CONTROLLER_REPLICAS for dynamicScaling * fix lint issues --------- Signed-off-by: Ishita Sequeira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does this PR do / why we need it:
Currently, when
spec.controller.sharding.dynamicScalingEnabledfeature is enabled on argocd-controller, we do not update the environment variableARGOCD_CONTROLLER_REPLICASwith the correct number of replicas on theargocd-application-controllerstatefulset.The PR fixes the logic of setting the number of replicas correctly in the environment variable of the statefulset pods.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes https://issues.redhat.com/browse/GITOPS-3465
How to test changes / Special notes to the reviewer: