Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Live resource view #267

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: Live resource view #267

wants to merge 7 commits into from

Conversation

jannfis
Copy link
Collaborator

@jannfis jannfis commented Jan 6, 2025

What does this PR do / why we need it:

This PR introduces functionality to provide live resource view from the agents to the control plane. It also lays the groundwork for remote log viewing.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

Checklist

  • Documentation update is required by this PR (and has been updated) OR no documentation update is required.

@jannfis jannfis force-pushed the feat/live-resource-view branch from d83a0f9 to a7c58b7 Compare January 6, 2025 15:33
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 36.54588% with 823 lines in your changes missing coverage. Please review.

Project coverage is 46.17%. Comparing base (c29e0dc) to head (262d0e2).

Files with missing lines Patch % Lines
cmd/principal/main.go 0.00% 93 Missing ⚠️
principal/server.go 14.94% 68 Missing and 6 partials ⚠️
agent/inbound.go 10.25% 70 Missing ⚠️
internal/resourceproxy/resourceproxy.go 55.20% 53 Missing and 3 partials ⚠️
internal/resourceproxy/options.go 32.46% 50 Missing and 2 partials ⚠️
cmd/cmdutil/log.go 0.00% 51 Missing ⚠️
internal/event/event.go 7.54% 49 Missing ⚠️
internal/argocd/cluster/informer.go 42.50% 34 Missing and 12 partials ⚠️
principal/resource.go 58.92% 37 Missing and 9 partials ⚠️
internal/resourceproxy/tracking.go 0.00% 34 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   48.19%   46.17%   -2.03%     
==========================================
  Files          55       73      +18     
  Lines        5054     6268    +1214     
==========================================
+ Hits         2436     2894     +458     
- Misses       2420     3118     +698     
- Partials      198      256      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
Signed-off-by: jannfis <[email protected]>
@jannfis jannfis force-pushed the feat/live-resource-view branch from e9f586d to 3044170 Compare January 7, 2025 01:12
Signed-off-by: jannfis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants