Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create a CallbackHandler for LlamaIndex #2

Conversation

kursathalat
Copy link
Contributor

As pointed out in argilla-io/argilla#4236 and #1, this PR creates the first version of the ArgillaCallbackHandler for llama-index.

@davidberenstein1957
Copy link
Member

Hi @kursathalat , I will review a bit later but feel free to already add thing related to readme.md etc, in a similar was as done within argilla-haystack

Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kursathalat , it is looking great already. As mentioned we can align the project setup for argilla-haystack. Additionally, we can enrich the information a bit with more metadata fields etc.

Finally, the process of setting this up should allow us to really improve the argilla-haystack integration with things we are able to log etc :)

src/llama_index_handler.py Outdated Show resolved Hide resolved
src/llama_index_handler.py Outdated Show resolved Hide resolved
src/llama_index_handler.py Outdated Show resolved Hide resolved
src/llama_index_handler.py Outdated Show resolved Hide resolved
src/llama_index_handler.py Outdated Show resolved Hide resolved
src/llama_index_handler.py Outdated Show resolved Hide resolved
src/llama_index_handler.py Outdated Show resolved Hide resolved
@davidberenstein1957 davidberenstein1957 marked this pull request as ready for review January 23, 2024 14:51
@davidberenstein1957 davidberenstein1957 merged commit 0848d23 into develop Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants