Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone #51

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix timezone #51

wants to merge 1 commit into from

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Sep 19, 2019

No description provided.

@areski
Copy link
Owner

areski commented Sep 20, 2019

Hi,

Could you give some context here? It seems you are fixing timezone but also adding a user model, why ?

@yihuang
Copy link
Contributor Author

yihuang commented Sep 20, 2019

Sorry for the confusion, the user field is for my use case.
I want non-superuser can only view his own data. I think the change is backward compatible.

@areski
Copy link
Owner

areski commented Sep 21, 2019

@PetrDlouhy your opinion on this will be appreciated :) ?

@PetrDlouhy
Copy link
Contributor

I am still confused what is this PR about.

@yihuang Can You please change this PR to include only changes related to single issue (and move the other changes to separate PR if needed) and change the title and description accordingly?

@yihuang
Copy link
Contributor Author

yihuang commented Sep 24, 2019

@PetrDlouhy OK, Just done that ;D

@PetrDlouhy
Copy link
Contributor

@yihuang Why is there the jquery fix? I am not sure what it fixes, and discussion about that should be part of another PR.

@yihuang
Copy link
Contributor Author

yihuang commented Oct 3, 2019

@PetrDlouhy I though django's jquery only expose window.jQuery, but I'm not sure now, so I'm revering this commit for the pull request now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants