Allow arbitrary and possibly unaligned writes to RDRAM through gdb #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemulate
force-pushed
the
gdb-rdram-writes
branch
from
5d740b4
to
6298733
Compare
|
Looks like the build is failing here for windows (x64 and arm64) and macOS. |
|
Missed an actual change ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow arbitrary writes through the GDB server to the RDRAM area. This was done in #1620, but that version has a subtle issue where the server will still refuse to write or change writes that happen to be of size
Byte|Half|Word|Dualif the addressed is not aligned to that size.This PR fixes the issue by checking if the write is to RDRAM first, allowing arbitrary and possibly unaligned writes. Otherwise, the write is handled through the normal machinery where these issues may be semantically important.