Skip to content

Commit

Permalink
handle rebase on 1697
Browse files Browse the repository at this point in the history
  • Loading branch information
jcm93 committed Nov 22, 2024
1 parent 36ecc57 commit 67b5c30
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion cmake/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ The recursive dependency resolver and platform helper functions then take over t

Unfortunately, the only way to handle these problems effectively and correctly (considering all platforms) is to recursively crawl the entire tree of dependencies for our targets and consider for each one what the appropriate course is with our final build product in mind.

The complexity of this code means that it makes up a non-trivial portion of the build system. However, these parts are quite important, as they enable our target-level build code to be completely platform-agnostic and unconcerned with the details of packaging and bundle construction. If we need to bundle another library, it's a simple matter of defining it and linking it to the appropriate target, and the build system handles the rest.
The complexity of this code means that it makes up a non-trivial portion of the build system. However, these parts are quite important, as they enable our target-level build code to be completely platform-agnostic and unconcerned with the details of packaging and bundle construction. If we need to bundle another library, it's a simple matter of defining it and linking it to the appropriate target, so that the build system may handle the rest.

> [!NOTE]
> This overview simplifies or omits certain CMake and platform implementation details to deliver a more concise overview of the build system. For the nitty-gritty of why all of this is actually necessary, see [Dependencies.md].
1 change: 0 additions & 1 deletion nall/cmake/sources.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ target_sources(
shared-pointer.hpp
stdint.hpp
string.hpp
stringize.hpp
suffix-array.hpp
terminal.cpp
terminal.hpp
Expand Down

0 comments on commit 67b5c30

Please sign in to comment.