Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ember 5.8 #44

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update to ember 5.8 #44

wants to merge 8 commits into from

Conversation

veelci
Copy link
Contributor

@veelci veelci commented May 10, 2024 •
edited
Loading

Update from Ember 3.28 to Ember 5.8

Things to note:

  • I did the upgrade in multiple stages.
  • I added the minified test styles to .stylelintignore since the minified boostrap styles were triggering linting errors
  • I switched the ci back over to npm to fix ci
  • formatters.formatZipcode(94606) returns a number instead of a string

@veelci veelci mentioned this pull request May 10, 2024
Closed
@veelci veelci mentioned this pull request May 10, 2024
Open
3 tasks
@veelci
Copy link
Contributor Author

veelci commented May 10, 2024

@arenoir Please review when you have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veelci @tabratton