Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement basic dead letter exchange behaviour #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aiomaster
Copy link
Contributor

I tried to implement a basic handling of dead-letter-exchanges.
If a message gets nacked or rejected it could be delivered in a dead letter exchange if specified in the arguments parameter of the queue options.
See here for details:
http://rubybunny.info/articles/extensions.html#dead_letter_exchange_dlx

I would be glad to get some feedback on this PR cause I don't know if this is a good idea and if the code is good enough.

@coveralls
Copy link

coveralls commented Oct 26, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 6729e0d on webit-de:master into 468fe86 on arempe93:master.

@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling b53c0fd on webit-de:master into 468fe86 on arempe93:master.

@arempe93
Copy link
Owner

arempe93 commented Nov 7, 2017

hey @aiomaster - thanks for the PR! i'll try to take a look and merge it soon 👍

@aiomaster
Copy link
Contributor Author

@arempe93 This would be great! I just tested it for direct exchanges with queues having a dead letter queue and the only way to get dead letters with bunny mock for now is by rejecting the message.
It would need more effort to simulate a dead lettering because of message timeout.
The last dead letter reason is a full queue, but this is also difficult with bunny-mock, cause you have to define what "full" means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants