Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with touch actions #2713

Open
wants to merge 3 commits into
base: 3.x
Choose a base branch
from
Open

Fix issues with touch actions #2713

wants to merge 3 commits into from

Conversation

13twelve
Copy link
Member

@13twelve 13twelve commented Jan 6, 2025 •
edited
Loading

Description

Fixes miscellaneous touch issues:

  • fixes actions inside dropdowns not firing (eg. adding a block)
  • increases cropping tool hit areas to make image cropping easier on touch devices

@13twelve
momentarily halt close of dropdowns to allow clicks inside
053c544 
and importantly, whilst allowing the dropdown to autoclose
@13twelve
stop trying to close a closed dropdown
23bbbe3 
which stops the side effect of immediately closing a dropdown
that you are trying to open
@13twelve
increase cropping point hit area
58fa2ec 
to make image cropping easier on touch devices
@13twelve 13twelve marked this pull request as ready for review January 7, 2025 16:08
@13twelve 13twelve changed the title WIP Fix issues with touch actions Fix issues with touch actions Jan 7, 2025
@13twelve 13twelve requested review from mrdoinel and ifox January 7, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoinel mrdoinel Awaiting requested review from mrdoinel

@ifox ifox Awaiting requested review from ifox

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@13twelve