pass model name for getModelController helper function #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
composer.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "area17/twill", | |||
| "name": "jwkuo/twill", | |||
There was a problem hiding this comment.
Why are you changing the name of the package?
There was a problem hiding this comment.
My bad, I was just trying to use this package to test and committed it to the 3.x branch. I've removed that.
|
Hello @jwkuo, your tests didn't pass and I left you a comment on your code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tweak for getting the Model Controller when belonging to a Capsule. TwillCapsules::getCapsuleForModel() expects the model name as a string.