Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WifiS3 add ping issue 251 #270

Closed
wants to merge 2 commits into from
Closed

WifiS3 add ping issue 251 #270

wants to merge 2 commits into from

Conversation

paulvha
Copy link
Contributor

@paulvha paulvha commented Feb 16, 2024 •
edited by per1234
Loading

This requires a change to bridge as well: arduino/uno-r4-wifi-usb-bridge#47

As such it also requires in the symbolic link file WiFiCommands.h that has been added (included in arduino/uno-r4-wifi-usb-bridge#47):

#define _PINGIP                  "+PINGIP"
#define _PINGNAME           "+PINGNAME"

@paulvha paulvha changed the title add ping WifiS3 add ping issue 251 Feb 16, 2024
@paulvha
Copy link
Contributor Author

paulvha commented Feb 16, 2024

Wifi.h and WiFi.cpp are NOT copied before compile. They are included in the pull requirest. What do I need to do ?

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 5, 2024
@per1234 per1234 linked an issue Jun 3, 2024 that may be closed by this pull request
WiFi.ping() function on WiFiS3 library doesn't exist #251
Closed
@pennam
Copy link
Contributor

pennam commented Nov 22, 2024

Hi @paulvha,
thanks for your contribution, I've took your commits, squashed and moved to #395 to add some fixes and changes to make the API compatible with WiFiNINA and WiFi101 ping.

@pennam pennam closed this Nov 22, 2024
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WiFi.ping() function on WiFiS3 library doesn't exist
3 participants
@paulvha @pennam @per1234