Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rev2] Fix AirQuality readings by restructuring BSEC library #84

Merged
merged 7 commits into from
Apr 4, 2024

Conversation

facchinm
Copy link
Contributor

@facchinm facchinm commented Apr 3, 2024

This library now has an additional dependency (https://github.com/boschsensortec/BSEC-Arduino-library) and every valid read from BME680 is cached and shared between the different abstractions.

@facchinm facchinm requested a review from Rocketct April 3, 2024 12:44
Copy link

github-actions bot commented Apr 3, 2024

Memory usage change @ e41650a

Board flash % RAM for global variables %
arduino:samd:mkrwifi1010 🔺 0 - +2504 0.0 - +0.96 🔺 0 - +64 0.0 - +0.2
Click for full report table
Board examples/Actuators/Buzzer_Melody
flash
% examples/Actuators/Buzzer_Melody
RAM for global variables
% examples/Actuators/Relays_blink
flash
% examples/Actuators/Relays_blink
RAM for global variables
% examples/All_Features
flash
% examples/All_Features
RAM for global variables
% examples/Grove_Inputs
flash
% examples/Grove_Inputs
RAM for global variables
% examples/LEDs-Examples/LED_Blink
flash
% examples/LEDs-Examples/LED_Blink
RAM for global variables
% examples/SD_card
flash
% examples/SD_card
RAM for global variables
% examples/Sensors/IMU/SimpleAccelerometer
flash
% examples/Sensors/IMU/SimpleAccelerometer
RAM for global variables
% examples/Sensors/IMU/SimpleGyroscope
flash
% examples/Sensors/IMU/SimpleGyroscope
RAM for global variables
% examples/Sensors/Light/FullExample
flash
% examples/Sensors/Light/FullExample
RAM for global variables
% examples/Sensors/Light/GestureSensor
flash
% examples/Sensors/Light/GestureSensor
RAM for global variables
% examples/Sensors/Light/ProximitySensor
flash
% examples/Sensors/Light/ProximitySensor
RAM for global variables
% examples/Sensors/Light/Read_Colors
flash
% examples/Sensors/Light/Read_Colors
RAM for global variables
% examples/Sensors/Pressure/ReadPressure
flash
% examples/Sensors/Pressure/ReadPressure
RAM for global variables
% examples/Sensors/Pressure/ReadPressureImperial
flash
% examples/Sensors/Pressure/ReadPressureImperial
RAM for global variables
% examples/Sensors/TemperatureHumidity/ReadSensors
flash
% examples/Sensors/TemperatureHumidity/ReadSensors
RAM for global variables
% examples/Sensors/TemperatureHumidity/ReadSensorsImperial
flash
% examples/Sensors/TemperatureHumidity/ReadSensorsImperial
RAM for global variables
% examples/Sensors/VOC/AirQuality
flash
% examples/Sensors/VOC/AirQuality
RAM for global variables
% examples/Sensors/VOC/CO2_Read
flash
% examples/Sensors/VOC/CO2_Read
RAM for global variables
% examples/Sensors/VOC/VolatileOrganicCompounds
flash
% examples/Sensors/VOC/VolatileOrganicCompounds
RAM for global variables
% examples/TouchPads/Custom_Sensitivity
flash
% examples/TouchPads/Custom_Sensitivity
RAM for global variables
% examples/TouchPads/Relays_control_Qtouch
flash
% examples/TouchPads/Relays_control_Qtouch
RAM for global variables
% examples/TouchPads/TouchTypes
flash
% examples/TouchPads/TouchTypes
RAM for global variables
% examples/TouchPads/Touch_and_LEDs
flash
% examples/TouchPads/Touch_and_LEDs
RAM for global variables
% examples/TouchPads/Touch_signals
flash
% examples/TouchPads/Touch_signals
RAM for global variables
% examples/TouchPads/getTouch
flash
% examples/TouchPads/getTouch
RAM for global variables
% examples/Display/Compose_images
flash
% examples/Display/Compose_images
RAM for global variables
% examples/Display/Graphics
flash
% examples/Display/Graphics
RAM for global variables
%
arduino:samd:mkrwifi1010 1128 0.43 24 0.07 1120 0.43 24 0.07 2488 0.95 56 0.17 1128 0.43 24 0.07 1120 0.43 24 0.07 1128 0.43 24 0.07 0 0.0 0 0.0 1128 0.43 24 0.07 1128 0.43 24 0.07 1128 0.43 24 0.07 1120 0.43 24 0.07 1128 0.43 24 0.07 2504 0.96 64 0.2 2504 0.96 64 0.2 2496 0.95 64 0.2 2496 0.95 64 0.2 2480 0.95 64 0.2 2496 0.95 64 0.2 2496 0.95 64 0.2 1128 0.43 32 0.1 1120 0.43 24 0.07 1120 0.43 32 0.1 1128 0.43 32 0.1 1128 0.43 24 0.07 1128 0.43 32 0.1 1128 0.43 24 0.07 1128 0.43 24 0.07
Click for full report CSV
Board,examples/Actuators/Buzzer_Melody<br>flash,%,examples/Actuators/Buzzer_Melody<br>RAM for global variables,%,examples/Actuators/Relays_blink<br>flash,%,examples/Actuators/Relays_blink<br>RAM for global variables,%,examples/All_Features<br>flash,%,examples/All_Features<br>RAM for global variables,%,examples/Grove_Inputs<br>flash,%,examples/Grove_Inputs<br>RAM for global variables,%,examples/LEDs-Examples/LED_Blink<br>flash,%,examples/LEDs-Examples/LED_Blink<br>RAM for global variables,%,examples/SD_card<br>flash,%,examples/SD_card<br>RAM for global variables,%,examples/Sensors/IMU/SimpleAccelerometer<br>flash,%,examples/Sensors/IMU/SimpleAccelerometer<br>RAM for global variables,%,examples/Sensors/IMU/SimpleGyroscope<br>flash,%,examples/Sensors/IMU/SimpleGyroscope<br>RAM for global variables,%,examples/Sensors/Light/FullExample<br>flash,%,examples/Sensors/Light/FullExample<br>RAM for global variables,%,examples/Sensors/Light/GestureSensor<br>flash,%,examples/Sensors/Light/GestureSensor<br>RAM for global variables,%,examples/Sensors/Light/ProximitySensor<br>flash,%,examples/Sensors/Light/ProximitySensor<br>RAM for global variables,%,examples/Sensors/Light/Read_Colors<br>flash,%,examples/Sensors/Light/Read_Colors<br>RAM for global variables,%,examples/Sensors/Pressure/ReadPressure<br>flash,%,examples/Sensors/Pressure/ReadPressure<br>RAM for global variables,%,examples/Sensors/Pressure/ReadPressureImperial<br>flash,%,examples/Sensors/Pressure/ReadPressureImperial<br>RAM for global variables,%,examples/Sensors/TemperatureHumidity/ReadSensors<br>flash,%,examples/Sensors/TemperatureHumidity/ReadSensors<br>RAM for global variables,%,examples/Sensors/TemperatureHumidity/ReadSensorsImperial<br>flash,%,examples/Sensors/TemperatureHumidity/ReadSensorsImperial<br>RAM for global variables,%,examples/Sensors/VOC/AirQuality<br>flash,%,examples/Sensors/VOC/AirQuality<br>RAM for global variables,%,examples/Sensors/VOC/CO2_Read<br>flash,%,examples/Sensors/VOC/CO2_Read<br>RAM for global variables,%,examples/Sensors/VOC/VolatileOrganicCompounds<br>flash,%,examples/Sensors/VOC/VolatileOrganicCompounds<br>RAM for global variables,%,examples/TouchPads/Custom_Sensitivity<br>flash,%,examples/TouchPads/Custom_Sensitivity<br>RAM for global variables,%,examples/TouchPads/Relays_control_Qtouch<br>flash,%,examples/TouchPads/Relays_control_Qtouch<br>RAM for global variables,%,examples/TouchPads/TouchTypes<br>flash,%,examples/TouchPads/TouchTypes<br>RAM for global variables,%,examples/TouchPads/Touch_and_LEDs<br>flash,%,examples/TouchPads/Touch_and_LEDs<br>RAM for global variables,%,examples/TouchPads/Touch_signals<br>flash,%,examples/TouchPads/Touch_signals<br>RAM for global variables,%,examples/TouchPads/getTouch<br>flash,%,examples/TouchPads/getTouch<br>RAM for global variables,%,examples/Display/Compose_images<br>flash,%,examples/Display/Compose_images<br>RAM for global variables,%,examples/Display/Graphics<br>flash,%,examples/Display/Graphics<br>RAM for global variables,%
arduino:samd:mkrwifi1010,1128,0.43,24,0.07,1120,0.43,24,0.07,2488,0.95,56,0.17,1128,0.43,24,0.07,1120,0.43,24,0.07,1128,0.43,24,0.07,0,0.0,0,0.0,1128,0.43,24,0.07,1128,0.43,24,0.07,1128,0.43,24,0.07,1120,0.43,24,0.07,1128,0.43,24,0.07,2504,0.96,64,0.2,2504,0.96,64,0.2,2496,0.95,64,0.2,2496,0.95,64,0.2,2480,0.95,64,0.2,2496,0.95,64,0.2,2496,0.95,64,0.2,1128,0.43,32,0.1,1120,0.43,24,0.07,1120,0.43,32,0.1,1128,0.43,32,0.1,1128,0.43,24,0.07,1128,0.43,32,0.1,1128,0.43,24,0.07,1128,0.43,24,0.07

@facchinm facchinm requested review from charlesbones and removed request for Rocketct and charlesbones April 4, 2024 08:06
@facchinm facchinm merged commit 1aba2ad into master Apr 4, 2024
6 checks passed
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants