-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix time validity check to account for maximum possible timezone offset #507
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 33 33
Lines 1520 1520
=======================================
Hits 1450 1450
Misses 70 70 ☔ View full report in Codecov by Sentry. |
@pennam could you review the PR? Would be very appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kytpbs,
thanks for your contribution and sorry for the delay I was OOF the past two weeks. I've got only one style change request. I suggested you the changes in order to match the comment style of the rest of the file.
Thanks
Co-authored-by: Mattia Pennasilico <[email protected]>
Thanks, tomorrow morning i will give this PR the last spin and then i will merge it. |
Memory usage change @ 14eff91
Click for full report table
Click for full report CSV
|
Hi @kytpbs I've made some tests and found a glitch with this changes:
I'm working to fix this regression and will propose you a couple of commits to be integrated in this PR. |
Hi @kytpbs I've prepared this two commits if you want to cherry-pick them and doublecheck your issue is fixed. |
at these lines #ifdef HAS_TCP
utc = getRemoteTime();
#endif
#ifdef HAS_LORA
/* Just keep incrementing stored RTC value*/
/* Just keep incrementing stored RTC value starting from EPOCH_AT_COMPILE_TIME */
utc = getRTC();
#endif shouldn't we first check if we have RTC and use that and return or vice versa, since if I know this is not part of the commits but it peaked my interest looking at the diffs |
Hi @kytpbs thanks for checking! None of the supported boards has both If user has defined a custom sync function, this method will be used otherwise if baord If in the future we will have a board with both TCP and LoRa probably it would be better to rewrite the function like this to avoid overwriting the value:
|
Thanks for the explanation I will double-check if the issue is fixed tonight if I can since it only occurs after 12 AM what should I do with your commits/branch
|
Just tested my branch and things worked correctly |
@kytpbs Thanks for the test! Please cherry-pick the commits on this branch so we can better keep track of this PR history and related issue. |
Superseded by #509 |
Fixes #506