-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to audioplayers v5 #345
Conversation
a9ba36d
to
7006833
Compare
f89d61b
to
da604ff
Compare
7736429
to
21d902a
Compare
@ardera I tested various functions of |
811f5b6
to
09696d0
Compare
Hey, sorry for the delay. In the meantime i pushed a big update to flutter-pi and lot of internal stuff changed (I also changed some small things in the audioplayers plugin in that update.) Can you rebase on top of master? Notably:
|
09696d0
to
07281b6
Compare
Hm I rebased, but for some reason now I cannot link flutter-pi
|
Didn't change anything in that regard, idk maybe delete the build folder and try again? |
Ok, I will try to figure out |
07281b6
to
d865b83
Compare
cba017c
to
59000aa
Compare
@ardera btw on current master there seem to be small ASAN issue:
|
59000aa
to
58dfcaf
Compare
I updated code base to, as far as I can see, latest version @ardera if you remember, was there any changes/bug fixes related to platform channels? |
Emit error if set source fails to set ready state Implement new release method Return NULL in align with audioplayers API Fix playbin identification in on media state change
58dfcaf
to
803afcd
Compare
@ardera Audio works again, please review when you have time. |
Fixes #344
Test code