-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make globalGqlIdentifierName case sensitive #5945
base: master
Are you sure you want to change the base?
make globalGqlIdentifierName case sensitive #5945
Conversation
Global identifiers are converted to lower case before being used in this file. This patch corrects the comparison function to so they match in the file if the source identifier is not all lower case
|
Why would we make it case insensitive? |
- don't lower case any globalGqlIdentifierNames
Totally works for me especially as identifiers are normally case sensitive. I just didn't want to break existing code ;) I've updated the branch |
d34fb65
to
b8bf584
Compare
Description
Currently globalGqlIdentifierNames are converted to lower case before being used for matching. This patch removes this conversion so they match in the file if the identifier in the code source is not all lower case. Previously if you had a mixed case globalGqlIdentifierName in the source code it would not match.
Eg:
const x = testGql(
could not be plucked using globalGqlIdentifierName as it is mixed case.It also re-enables tests
Related # 5944
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Test Environment:
@graphql-tools/...
: masterChecklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments