Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Leverage local rate limiting if available in environment #205

Closed
wants to merge 3 commits into from

Conversation

blaine-arcjet
Copy link
Contributor

@blaine-arcjet blaine-arcjet commented Feb 7, 2024

This implements tracking local rate limits

Closes #50

Copy link

trunk-io bot commented Feb 7, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@blaine-arcjet blaine-arcjet force-pushed the phated/local-rate-limit branch from c354c30 to cc15dec Compare February 8, 2024 20:17
@blaine-arcjet blaine-arcjet changed the base branch from main to phated/cookies-and-query February 8, 2024 20:17
Base automatically changed from phated/cookies-and-query to main February 8, 2024 20:50
@blaine-arcjet blaine-arcjet force-pushed the phated/local-rate-limit branch from 96df5c9 to ee6505f Compare February 8, 2024 23:46
Base automatically changed from phated/externalize-wasm-edge to main February 9, 2024 15:53
trunk-io bot pushed a commit that referenced this pull request Feb 9, 2024
…217)

This change externalizes any file we import that ends in `.wasm?module` and links to the cloudflare worker documentation. This is a cleaner solution than what existed once we start adding more wasm modules, such as [Rate Limit](#205).
trunk-io bot pushed a commit that referenced this pull request Feb 9, 2024
@blaine-arcjet
Copy link
Contributor Author

We've decided that local rate limit only has limited benefits to the users, so we're going to close this out as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide local rate limit rule within TypeScript SDK if supported by environment
1 participant