-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: refactor wasm loading for analyze #1832
Conversation
😎 Merged successfully - details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want this logic only available via rules. The linked issue says we need to create an @arcjet/analyze-wasm
package.
@blaine-arcjet Just to clarify before I make the changes. You're proposing we have an |
Correct. I expect that |
Great! I'll update this PR to do that then. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
@e-moran one thing I wanted to flag here is that I didn't see a sibling PR to change the build scripts in our analyze packages. We'll want both of them submitted before we merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs some cleanup. I also expressed some thoughts on how we could reduce some more boilerplate.
Co-authored-by: blaine-arcjet <[email protected]>
Co-authored-by: blaine-arcjet <[email protected]>
…js into eoin/refactor-wasm-loader
Refactors wasm loading so that the
analyze
package only exports an initialisation function. This greately reduces the amount of code duplication, because we don't need functions per-wasm function per-runtime.Closes #1448