Skip to content

Commit

Permalink
deps: Upgrade typescript-eslint packages (#2478)
Browse files Browse the repository at this point in the history
I'm working to cleaning up some of our exclusions and the typescript-eslint packages are the most straightforward since they support eslint v8 & v9. We'll need this to upgrade to eslint 9.
  • Loading branch information
blaine-arcjet authored Dec 9, 2024
1 parent 06b5b21 commit c45bdfd
Show file tree
Hide file tree
Showing 17 changed files with 937 additions and 1,347 deletions.
32 changes: 0 additions & 32 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ updates:
# TODO(#539): Upgrade to eslint 9
- dependency-name: eslint
versions: [">=9"]
- dependency-name: "@typescript-eslint/parser"
versions: [">=8"]
- dependency-name: "@typescript-eslint/eslint-plugin"
versions: [">=8"]
# Ignore updates for Buf and ConnectRPC v2 and above
- dependency-name: "@bufbuild/protobuf"
versions: [">=2"]
Expand Down Expand Up @@ -199,10 +195,6 @@ updates:
# TODO(#539): Upgrade to eslint 9
- dependency-name: eslint
versions: [">=9"]
- dependency-name: "@typescript-eslint/parser"
versions: [">=8"]
- dependency-name: "@typescript-eslint/eslint-plugin"
versions: [">=8"]

- package-ecosystem: npm
directory: /examples/nestjs-fastify
Expand All @@ -226,10 +218,6 @@ updates:
# TODO(#539): Upgrade to eslint 9
- dependency-name: eslint
versions: [">=9"]
- dependency-name: "@typescript-eslint/parser"
versions: [">=8"]
- dependency-name: "@typescript-eslint/eslint-plugin"
versions: [">=8"]

- package-ecosystem: npm
directory: /examples/nestjs-graphql
Expand All @@ -256,10 +244,6 @@ updates:
# TODO(#539): Upgrade to eslint 9
- dependency-name: eslint
versions: [">=9"]
- dependency-name: "@typescript-eslint/parser"
versions: [">=8"]
- dependency-name: "@typescript-eslint/eslint-plugin"
versions: [">=8"]

- package-ecosystem: npm
directory: /examples/nestjs-launchdarkly
Expand All @@ -286,10 +270,6 @@ updates:
# TODO(#539): Upgrade to eslint 9
- dependency-name: eslint
versions: [">=9"]
- dependency-name: "@typescript-eslint/parser"
versions: [">=8"]
- dependency-name: "@typescript-eslint/eslint-plugin"
versions: [">=8"]

- package-ecosystem: npm
directory: /examples/nextjs-14-nextauth-4
Expand Down Expand Up @@ -646,10 +626,6 @@ updates:
# TODO(#539): Upgrade to eslint 9
- dependency-name: eslint
versions: [">=9"]
- dependency-name: "@typescript-eslint/parser"
versions: [">=8"]
- dependency-name: "@typescript-eslint/eslint-plugin"
versions: [">=8"]

- package-ecosystem: npm
directory: /examples/nextjs-sensitive-info
Expand Down Expand Up @@ -827,10 +803,6 @@ updates:
# TODO(#539): Upgrade to eslint 9
- dependency-name: eslint
versions: [">=9"]
- dependency-name: "@typescript-eslint/parser"
versions: [">=8"]
- dependency-name: "@typescript-eslint/eslint-plugin"
versions: [">=8"]

- package-ecosystem: npm
directory: /examples/sveltekit
Expand All @@ -854,7 +826,3 @@ updates:
# TODO(#539): Upgrade to eslint 9
- dependency-name: eslint
versions: [">=9"]
- dependency-name: "@typescript-eslint/parser"
versions: [">=8"]
- dependency-name: "@typescript-eslint/eslint-plugin"
versions: [">=8"]
5 changes: 4 additions & 1 deletion arcjet-nest/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,10 @@ function decorate(decorators: any[], target: any, key?: any, desc?: any): any {

// Creates a decorator for a constructor parameter. Pulled out of `tslib` to
// avoid build failures.
function param(paramIndex: number, decorator: Function): Function {
function param(
paramIndex: number,
decorator: (target: any, key: any, paramIndex: number) => void,
) {
return function (target: any, key: any) {
decorator(target, key, paramIndex);
};
Expand Down
2 changes: 2 additions & 0 deletions eslint-config/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ module.exports = {
"@typescript-eslint/ban-types": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-unused-vars": "off",
// TODO: Evaluate our usage of `{}` types
"@typescript-eslint/no-empty-object-type": "off",
"no-unused-vars": "off",
},
parser: "@typescript-eslint/parser",
Expand Down
4 changes: 2 additions & 2 deletions eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"lint": "eslint ."
},
"dependencies": {
"@typescript-eslint/eslint-plugin": "7.18.0",
"@typescript-eslint/parser": "7.18.0",
"@typescript-eslint/eslint-plugin": "8.17.0",
"@typescript-eslint/parser": "8.17.0",
"eslint-config-prettier": "9.1.0",
"eslint-config-turbo": "2.3.3"
},
Expand Down
Loading

0 comments on commit c45bdfd

Please sign in to comment.