Digital Object delete #55
Open
+101
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacksmith-welder
force-pushed
the
digital_object_delete
branch
from
c9af4d0 to
7f30ee5
Compare
blacksmith-welder
force-pushed
the
digital_object_delete
branch
from
72afd50 to
b87b02f
Compare
blacksmith-welder
added
to be reviewed by kdimopulu
and removed
requires step definitions
labels
blacksmith-welder
force-pushed
the
master
branch
2 times, most recently
from
fe6d90c to
4eb3d63
Compare
blacksmith-welder
requested review from
thimios,
balmas,
brianzelip and
donaldjosephsmith
|
|
||
| click_on 'Save' | ||
|
|
||
| wait_for_ajax |
There was a problem hiding this comment.
Are you finding that wait_for_ajax is actually necessary here? It probably doesn't hurt (other than the time taken by sleep), but there shouldn't be any AJAX stuff going on here as the Save button just does a standard form submit.
There was a problem hiding this comment.
When you click on Save, the page reloads and then you are in the digital object edit page, which loads the edit form by doing a request at digital_objects/20/edit?inline=true. After the wait_for_ajax, we are expecting a success message, which is part of this inline form.
Running this test locally, seems to always succeed without wait_for_ajax, but we have experienced failing tests in similar occasions, that is why it is used here.
This was referenced Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.