Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error handling #4

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

maxime-rainville
Copy link
Member

@maxime-rainville maxime-rainville commented Dec 2, 2024

This PR ads the ability to pass a logger to the disptacher and a config option to let exception bubble up.

Blocks

Copy link

@marwan38 marwan38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe exposing a callback for error handling is a objectively better api design here

examples/basic-usage.php Outdated Show resolved Hide resolved
src/AsyncEventDispatcher.php Outdated Show resolved Hide resolved
@maxime-rainville maxime-rainville force-pushed the pull/0/add-better-error-handling branch from b22bff1 to 3a87027 Compare December 12, 2024 04:03
@maxime-rainville maxime-rainville merged commit f925a65 into 0 Dec 13, 2024
8 checks passed
@maxime-rainville maxime-rainville deleted the pull/0/add-better-error-handling branch December 13, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants