Improve partition_load_balance
#2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant MPI call for global gid list - Make GJ table local - Extract connection table builing.
- add group parameters struct to bundle info - coral temporary structures into their own scopes to avoid RSS growth.
Also, add weird test to see that we can _almost_ construct the partition.
boeschf
reviewed
Aug 17, 2023
boeschf
reviewed
Sep 5, 2023
| ctx->distributed = std::make_shared<distributed_context>(dummy_context{rank, nranks}); | ||
| for (const auto& R: {gj_symmetric(nranks, true), gj_symmetric(nranks, false)}) { | ||
| // NOTE: This is a bit silly, but allows us to test _most_ of | ||
| // the invariants without proper MPI support. If we could get `gather_gids` to |
There was a problem hiding this comment.
just curious: can you think of a way to make gather_gids work?
There was a problem hiding this comment.
Not really without major surgery. We could split this function into three, tentatively:
- register groups, called in parallel and shoving the data into the decomposition
- gather_gids, collective call
- actually construct the decomposition
but that'll require putting the data threaded between those calls into the decomposition
since they must be independent and pass around some state.
|
@boeschf the failure seems to be a timeout on CSCS CI/CD?! |
|
@boeschf any news here? |
boeschf
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin-off from #2005. Make the primary load balancing cleaner and faster and more maintainable.
Thus:
super_cellsvsregular_cellsPartially inspired by external feedback