Connect groups to a workspace #905
Open
+2,597
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zak39
added
backend
zak39
force-pushed
the
feature/connexion-to-groups
branch
2 times, most recently
from
803cd80 to
ac2135c
Compare
|
Hi @smarinier :) You don't need this change : ac0e880 . It is already present in the main branch : workspace/.github/workflows/php.yml Lines 15 to 19 in 6a6cbb6 We just need to rebase our branch with the main branch. I could do it if you want 😉 |
zak39
force-pushed
the
feature/connexion-to-groups
branch
from
ac0e880 to
8e73cf5
Compare
zak39
force-pushed
the
feature/connexion-to-groups
branch
from
46731ba to
273d238
Compare
zak39
force-pushed
the
feature/connexion-to-groups
branch
from
6f77dd8 to
71bb9bc
Compare
zak39
force-pushed
the
feature/connexion-to-groups
branch
2 times, most recently
from
00530ee to
2ee5544
Compare
WorkSpace must be considered as dav types, in order to boot on dav requests. by @smarinier.
We can add connected groups (or added groups) to workspaces. These groups can be LDAP or local, and when we add a connected group, we also add its users. In this feature, we return a slug of a gid. This slug handles special characters, making it more suitable for rendering in the browser's URL.
…ddleware Retrieve the spaceId from the request if it is provided by the data from the controllers and check whether it is null or not.
Added the connected groups to the UserService and SpaceManager tests.
zak39
force-pushed
the
feature/connexion-to-groups
branch
from
2ee5544 to
f3c1be8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a draft for the moment.
OP#3293