Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes it possible to select users only one by one in the SelectUsers' MultiSelect #348

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

StCyr
Copy link
Collaborator

@StCyr StCyr commented Sep 24, 2021

Fixes #345 and #341

Signed-off-by: Cyrille Bollu [email protected]

@StCyr StCyr added feature Ask for a new feature or new feature frontend Modification related to frontend redesign Ask for a redesign of an existing feature labels Sep 24, 2021
@StCyr StCyr requested a review from zak39 September 24, 2021 08:24
@StCyr StCyr self-assigned this Sep 24, 2021
@StCyr StCyr linked an issue Sep 24, 2021 that may be closed by this pull request
@StCyr StCyr force-pushed the fix/345/users-disaplyed-twice-in-selectusers-modal branch from 454f4cf to a86631e Compare September 24, 2021 08:27
@zak39
Copy link
Collaborator

zak39 commented Sep 24, 2021

It's okay !

Can I accept your PR ? 😉

@LivOriona
Copy link
Collaborator

@StCyr can you make me a screenshot or gif (or show me directly) of the result of this PR before accepting it?
( @zak39 )

@zak39
Copy link
Collaborator

zak39 commented Sep 27, 2021

@StCyr can you make me a screenshot or gif (or show me directly) of the result of this PR before accepting it?
( @zak39 )

Hey @LivOriona !

This here a gif of the result :

select-one-by-one-users

Can you confirm us @StCyr ?

@LivOriona
Copy link
Collaborator

Thanks you, it's perfect like this. You can accept the PR if everything is ok for you @zak39 and @StCyr.

@StCyr
Copy link
Collaborator Author

StCyr commented Sep 28, 2021

yes, everything is ok for me

@zak39 zak39 merged commit 4645550 into main Sep 28, 2021
@zak39 zak39 deleted the fix/345/users-disaplyed-twice-in-selectusers-modal branch June 30, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Ask for a new feature or new feature frontend Modification related to frontend redesign Ask for a redesign of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preselected users displayed twice Close the search field once a user is selected
3 participants