missing added_groups in JSON and JS #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zak39
reviewed
Jun 17, 2024
| @@ -75,6 +75,7 @@ export default { | |||
| color: space.color_code, | |||
| groupfolderId: space.groupfolder_id, | |||
| groups: space.groups, | |||
| added_groups: space.added_groups ?? [], | |||
There was a problem hiding this comment.
Normally, it's not necessary, as you will always return an empty array, no? 🤔
|
Could you run |
Prefer not do that, as my cs fix is not the same as yours, and it modifies a lot of stuff (mainly your code) |
Okay... Could I run the command on my side? |
smarinier
force-pushed
the
fix/crashed_on_missing_added_groups
branch
2 times, most recently
from
2685994 to
0f6db84
Compare
smarinier
force-pushed
the
fix/crashed_on_missing_added_groups
branch
from
0f6db84 to
bd74d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rahhhh