Merge branch 'update-styles'

arathunku · Mar 30, 2024 · c1e6882 · c1e6882
2 parents 6b8346f + a2521fd
commit c1e6882
Show file tree

Hide file tree

Showing 17 changed files with 307 additions and 261 deletions.
diff --git a/.credo.exs b/.credo.exs
@@ -3,7 +3,7 @@
     %{
       name: "default",
       files: %{
-        included: ["lib/", "src/", "web/", "apps/"],
+        included: ["lib/", "src/"],
         excluded: []
       },
       plugins: [],
@@ -22,7 +22,7 @@
           # Some rules have a comment before them explaining ways Styler deviates from the Credo rule.
           #
           # always expands `A.{B, C}`
-          {Credo.Check.Consistency.MultiAliasImportRequireUse, false},
+          # {Credo.Check.Consistency.MultiAliasImportRequireUse, false},
           # including `case`, `fn` and `with` statements
           {Credo.Check.Consistency.ParameterPatternMatching, false},
           # Styler implements this rule with a depth of 3 and minimum repetition of 2
@@ -53,13 +53,19 @@
           {Credo.Check.Refactor.MapInto, false},
           # in pipes only
           {Credo.Check.Refactor.MapJoin, false},
-          {Credo.Check.Refactor.NegatedConditionsInUnless, false},
-          {Credo.Check.Refactor.NegatedConditionsWithElse, false},
+          # {Credo.Check.Refactor.NegatedConditionsInUnless, false},
+          # {Credo.Check.Refactor.NegatedConditionsWithElse, false},
           # allows ecto's `from
           {Credo.Check.Refactor.PipeChainStart, false},
           {Credo.Check.Refactor.RedundantWithClauseResult, false},
           {Credo.Check.Refactor.UnlessWithElse, false},
-          {Credo.Check.Refactor.WithClauses, false}
+          {Credo.Check.Refactor.WithClauses, false},
+
+          # custom ext_fit rules
+          {Credo.Check.Refactor.Nesting, false},
+          {Credo.Check.Refactor.CyclomaticComplexity, false},
+          {Credo.Check.Design.TagFIXME, false},
+          {Credo.Check.Design.TagTODO, false}
         ]
       }
     }

diff --git a/.github/workflows/elixir-quality-checks.yml b/.github/workflows/elixir-quality-checks.yml
@@ -35,10 +35,10 @@ jobs:
         # Check formatting even if there were unused deps so that
         # we give devs as much feedback as possible & save some time.
         if: always()
-      # - name: Run Credo
-      #   run: mix credo suggest --min-priority=normal
-      #   # Run Credo even if formatting or the unused deps check failed
-      #   if: always()
+      - name: Run Credo
+        run: mix credo suggest --min-priority=normal
+        # Run Credo even if formatting or the unused deps check failed
+        if: always()
       # - name: Check for compile-time dependencies
       #   run: mix xref graph --label compile-connected --fail-above 0
       #   if: always()

diff --git a/lib/ext_fit.ex b/lib/ext_fit.ex
@@ -1,7 +1,7 @@
 defmodule ExtFit do
-  @external_resource "README.md"
   @moduledoc "README.md"
              |> File.read!()
              |> String.split("<!-- @moduledoc -->")
              |> Enum.fetch!(1)
+  @external_resource "README.md"
 end