This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Add landscape and page size support to weaver #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szeber
commented
Aug 30, 2018
| } | ||
|
|
||
| // constructCMD returns a string array containing the AthenaPDF command to be | ||
| // executed by Go's os/exec Output. It does this using a base command, and path | ||
| // string. | ||
| // It will set an additional '-A' flag if aggressive is set to true. | ||
| // See athenapdf CLI for more information regarding the aggressive mode. | ||
| func constructCMD(base string, path string, aggressive bool) []string { | ||
| func constructCMD(base string, path string, aggressive bool, noPortrait bool, pageSize string) []string { |
There was a problem hiding this comment.
Also IMHO this method should receive the AthenaPDF instance and take the params from there. Not sure why the struct was split out to separate params.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weaver doesn't support setting the page size and the page orientation to the cli.
On a related side note the cli's switch for the page orientation is not the same as wkhtmltopdf's so that prevents it from being a drop in replacement.