This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
rgw/sfs: init bucket mtime and store it #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecluis
added
kind/enhancement
irq0
reviewed
Oct 23, 2023
| @@ -223,6 +227,9 @@ TEST_F(TestSFSBucket, UserCreateBucketCheckGotFromCreate) { | |||
| } | |||
|
|
|||
| EXPECT_EQ(bucket_from_create->get_acl(), arg_aclp); | |||
| EXPECT_TRUE( | |||
| bucket_from_create->get_modification_time().time_since_epoch().count() > 0 | |||
There was a problem hiding this comment.
I think real_clock::is_zero(ts) is the canonical way to check that the timestamp is not zero.
Suggest replacing with EXPECT_NE(real_clock::is_zero(bucket_from_create->get_modification_time()))
jecluis
force-pushed
the
wip-sfs-fix-bucket-mtime
branch
from
c1352f0 to
fabb8c2
Compare
Signed-off-by: Joao Eduardo Luis <[email protected]>
jecluis
force-pushed
the
wip-sfs-fix-bucket-mtime
branch
from
fabb8c2 to
e26d9a7
Compare
|
@irq0 please take another look. I'd love to put this one behind us :) |
irq0
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: aquarist-labs/s3gw-tools#174
Signed-off-by: Joao Eduardo Luis <[email protected]>