This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
rgw/sfs: mark all OPEN versions DELETED on startup #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tserong
force-pushed
the
wip-set-open-to-deleted-on-startup
branch
from
8556363 to
94cbb5d
Compare
jecluis
previously approved these changes
Oct 22, 2023
jecluis
added
kind/enhancement
irq0
reviewed
Oct 23, 2023
All OPEN versions that exist on startup are due to aborted uploads. Setting them to DELETED allows us to free up space leveraging the GC. Tested by running `s3cmd --limit-rate 1000 put obj.1mb.bin s3://foo/slow` and hitting CTRL-C after a few seconds to leave an open object lying around, then restarting s3gw and looking for "marked 1 open objects deleted" in the debug logs. Fixes: https://github.com/aquarist-labs/s3gw/issues/624 Signed-off-by: Tim Serong <[email protected]>
tserong
force-pushed
the
wip-set-open-to-deleted-on-startup
branch
from
94cbb5d to
3a1895f
Compare
irq0
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All OPEN versions that exist on startup are due to aborted uploads. Setting them to DELETED allows us to free up space leveraging the GC.
Tested by running
s3cmd --limit-rate 1000 put obj.1mb.bin s3://foo/slowand hitting CTRL-C after a few seconds to leave an open object lying around, then restarting s3gw and looking for "marked 1 open objects deleted" in the debug logs.Fixes: https://github.com/aquarist-labs/s3gw/issues/624
Checklist