This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
rgw/sfs: Allow multiple delete markers #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes how delete markers are stored and retrieved. As stated in [Amazon docs](https://docs.aws.amazon.com/AmazonS3/latest/userguide/ManagingDelMarkers.html) multiple delete markers are allowed and are stacked as just another version. Another possible reason why this is supported is to track the history of a version. Fixes: https://github.com/aquarist-labs/s3gw/issues/718 Signed-off-by: Xavi Garcia <[email protected]>
The IsLatest logic in SQLiteList ::version needs to be adapted to fix issue 718. Should be similar to the changes in this PR (removing the sort by version type) |
Signed-off-by: Xavi Garcia <[email protected]>
Oh, right... I forgot about that class, should be fixed now. I also added a small unit test. Thanks! |
irq0
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how delete markers are stored and retrieved. As stated in Amazon
docs multiple delete markers are allowed and are stacked as just another version.
Another possible reason why this is supported is to track the history of a version.
Fixes: https://github.com/aquarist-labs/s3gw/issues/718
Signed-off-by: Xavi Garcia [email protected]
Checklist