Merge pull request #4 from basselAhmed/master

Fix a bug when updating props Thank you @basselAhmed , Never checked that case since we always had `VALUE` as `defaultValueType`.
apxor · Nov 2, 2018 · 383288b · 383288b
2 parents e67fd1f + fc86cb1
commit 383288b
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 9 deletions.
diff --git a/lib/reactcohortgraph.js b/lib/reactcohortgraph.js
@@ -2745,10 +2745,16 @@ var ReactCohortGraph = function (_React$Component) {
                         dataStore: store
                     });
                 } else {
-                    this.setState({
-                        currentType: currentDataType,
-                        valueType: valueType
-                    });
+                    if (valueType) {
+                        this.setState({
+                            currentType: currentDataType,
+                            valueType: valueType
+                        });
+                    } else {
+                        this.setState({
+                            currentType: currentDataType
+                        });
+                    }
                 }
                 if (typeof onStoreUpdate === 'function') {
                     onStoreUpdate(store, currentDataType, valueType);

diff --git a/lib/reactcohortgraph.min.js b/lib/reactcohortgraph.min.js
diff --git a/src/ReactCohortGraph.js b/src/ReactCohortGraph.js
@@ -68,10 +68,16 @@ class ReactCohortGraph extends React.Component {
                     dataStore: store
                 });
             }else{
-                this.setState({
-                    currentType: currentDataType,
-                    valueType: valueType
-                });
+                if (valueType) {
+                    this.setState({
+                        currentType: currentDataType,
+                        valueType: valueType
+                    });
+                } else {
+                    this.setState({
+                        currentType: currentDataType,
+                    });
+                }
             }
             if(typeof onStoreUpdate === 'function') {
                 onStoreUpdate(store, currentDataType, valueType);