-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated http client from net/http to fasthttp #96
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally good, but my main concern is that it doesn't support HTTP/2?
Hey @gregnazario, |
All of the Aptos labs endpoints built in by default support HTTP/2 as far as I know, which by itself should give more performance boost than the handling on the client side afaik. I found when I set the client pool configuration correctly, I got good concurrency and performance out of it |
Yeah, the connection pool management for this library is far better and it's architected in a manner wherein user have the control over when they want to release the request and response body thereby mitigating memory leaks. |
Description
Modified Aptos Http client from
net/http
tofasthttp
. There has been issues with connection issues with newer Aptos blockchain like Movement.Test Plan
Related Links