COVERAGE: Fix/with sources ignored #1405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was already a lot of options for one method and I am going to add another one in the next commit.
Such as e.g. downloading 'glibc' when the sources for 'libc6' are requested.
The fix of the -with-filter flag causes the following previously missing source files to be downloaded, so I updated the test file. ``` rkward_0.7.5-1~bullseyecran.0.debian.tar.xz rkward_0.7.5-1~bullseyecran.0.dsc rkward_0.7.5.orig.tar.gz rpy2_3.5.12-1~bullseyecran.0.debian.tar.xz rpy2_3.5.12-1~bullseyecran.0.dsc rpy2_3.5.12.orig.tar.gz ```
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1405 +/- ##
==========================================
+ Coverage 74.81% 74.89% +0.07%
==========================================
Files 157 157
Lines 18180 18261 +81
==========================================
+ Hits 13602 13676 +74
- Misses 3470 3476 +6
- Partials 1108 1109 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
Checklist
AUTHORS