Updates for Modern 7.2 #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egreer
reviewed
Oct 11, 2024
Dockerfile
Outdated
| WORKDIR $APP_HOME | ||
|
|
||
| # Update Gems first...only re-do this when bundler version changes. | ||
| # If we need to force a gem update we'll have to `--no-cache` or add a file we can copy in | ||
| RUN gem update --system && gem install bundler:2.3.25 |
There was a problem hiding this comment.
Should upgrade bundler to latest version
Dockerfile
Outdated
| postgresql13-dev \ | ||
| vips-dev \ | ||
| && rm ./apk-updated-date.txt \ | ||
| && npm install -g [email protected] |
There was a problem hiding this comment.
Drop font libraries, pandoc, chrome,
Do we need to upgrade postgresql13 or still latest library?
Dockerfile
Outdated
| RUN bundle install && rm ./Gemfile ./Gemfile.lock | ||
|
|
||
| COPY ./server/deploy/minimagick/policy.xml /etc/ImageMagick-6/ | ||
| COPY ./server $APP_HOME/ |
There was a problem hiding this comment.
Change these all from ./server
Dockerfile
Outdated
|
|
||
| # copy all font files to the font install directory, so chromium can use these fonts directly | ||
| # this way we don't have to embed fonts in the HTML | ||
| RUN find lib/assets/fonts -name '*.ttf' -exec ln '{}' /usr/share/fonts/ \; |
| group :development, :test do | ||
| gem 'bullet' | ||
| gem 'byebug', platforms: [:mri, :mingw, :x64_mingw] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.