Fix: container start commands #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In Python, we switched from Flask to asynciohttp library.
With that, start command changed. CLI has start-command hard-coded, so we need to update it.
What I did instead is used helper bash script. This resolves the problem, and also ensures it doesn't happen in future. Those start helpers are what Open Runtimes tests use, so they are always 100% reliable.
I only manually tested everything working properly with Python and Node, but start helper is used for all runtime tests in Open Runtimes, so it gives me confidence it's not breaking anything currently working fine.
Fixes appwrite/appwrite#8902
Test Plan
Before:
After:
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes