Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested object serialization with generics #1004

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

abnegate
Copy link
Contributor

@abnegate abnegate commented Oct 23, 2024

What does this PR do?

Enums implementation caused an issue with serializing nested objects when using the generic versions of methods in Swift/Apple

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Copy link
Member

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest looks good

CONTRIBUTING.md Outdated Show resolved Hide resolved
src/SDK/Language.php Outdated Show resolved Hide resolved
@abnegate abnegate merged commit ab19a13 into master Nov 6, 2024
34 checks passed
@abnegate abnegate deleted the fix-apple-generic-serialization branch November 6, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants