Add admin certificate invalidation step to install #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastjan
changed the title
haasad
approved these changes
Mar 8, 2024
I think it is valid to setup the "standard" login independently. Might be due to special customer needs or whatever. Until then it is still better to use emergency-credentials than passing around the admin kubeconfig. |
bastjan
force-pushed
the
add-emergency-credential-check-and-admin-inval-to-install
branch
from
6b278f9
to
3a34aeb
Compare
Also adds check for emergency credentials.
bastjan
force-pushed
the
add-emergency-credential-check-and-admin-inval-to-install
branch
from
3a34aeb
to
cde0840
Compare
|
yes, that makes sense |
bastjan
deleted the
add-emergency-credential-check-and-admin-inval-to-install
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds check for emergency credentials.