Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application-log-reader ClusterRole not aggregating to admin Clust… #151

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

DebakelOrakel
Copy link
Contributor

@DebakelOrakel DebakelOrakel commented Aug 15, 2024

…erRole

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@DebakelOrakel DebakelOrakel added the bug Something isn't working label Aug 15, 2024
@DebakelOrakel DebakelOrakel requested a review from a team as a code owner August 15, 2024 15:28
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for implementing 😊

@DebakelOrakel DebakelOrakel merged commit a842846 into master Aug 15, 2024
18 checks passed
@DebakelOrakel DebakelOrakel deleted the fix/logging-role branch August 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants