Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use display name as title #555

Merged
merged 10 commits into from
Sep 6, 2023
Merged

Use display name as title #555

merged 10 commits into from
Sep 6, 2023

Conversation

steffinchen
Copy link
Contributor

@steffinchen steffinchen commented Aug 23, 2023

Summary

Uses the entity's display name as title and in messages, if the display name is not set, falls back to the entity's name.

Changes

  • Display name as title for lists, forms, and in messages
  • Summary cards in the overview list for Billing, Organizations, and Teams now also show the ID (aka metadata.name) as it's not the visual title anymore
Screenshots Screenshot Billing List Screenshot Teams Overview Screenshot Organizations View

Closes #492

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking,
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@steffinchen steffinchen added the enhancement New feature or request label Aug 23, 2023
@steffinchen steffinchen self-assigned this Aug 23, 2023
@steffinchen steffinchen requested a review from a team as a code owner August 23, 2023 09:20
@steffinchen
Copy link
Contributor Author

@corvus-ch Now that the display name is used as visual title, the name (sometimes also called ID) isn't shown anymore when editing an entity (see screenshot). Is it relevant or useful for the user to see it? One possibility would be to add it to the visual title in parentheses (see 2nd screenshot for an example). What do you think?

Display name only:
Screenshot Edit Team

Display name with ID:
Screenshot Edit Team with Id in Title

src/app/display-name.pipe.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

🚀 Preview deployment active

App URL https://portal-pr-555-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision 891ab41
Helm release appuio-control-api-preview/portal-pr-555
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

@steffinchen steffinchen temporarily deployed to preview August 23, 2023 10:57 — with GitHub Actions Inactive
@steffinchen steffinchen temporarily deployed to preview August 23, 2023 10:58 — with GitHub Actions Inactive
@github-actions
Copy link

🚀 Preview deployment active

App URL https://portal-pr-555-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision fd6461e
Helm release appuio-control-api-preview/portal-pr-555
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

Copy link
Contributor

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corvus-ch Now that the display name is used as visual title, the name (sometimes also called ID) isn't shown anymore when editing an entity […]. Is it relevant or useful for the user to see it?

Yes, I think this is useful to see.

One possibility would be to add it to the visual title in parentheses (see 2nd screenshot for an example). What do you think?

That, or just keep the ID as title in the edit. My argument: the ID is constant and cannot be changed. The Display name however can be changed. I find it confusing, if I can change something in an input field, but the old value is still visible at another place.

@steffinchen
Copy link
Contributor Author

That, or just keep the ID as title in the edit. My argument: the ID is constant and cannot be changed. The Display name however can be changed. I find it confusing, if I can change something in an input field, but the old value is still visible at another place.

That's a good point. I've changed all the edit form titles, so they show the entity's id.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🚀 Preview deployment active

App URL https://portal-pr-555-appuio-control-api-preview.apps.cloudscale-lpg-2.appuio.cloud
Revision de459a1
Helm release appuio-control-api-preview/portal-pr-555
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

@steffinchen steffinchen merged commit dce4880 into master Sep 6, 2023
7 checks passed
@steffinchen steffinchen deleted the 492-display-name-as-title branch September 6, 2023 09:34
@steffinchen steffinchen temporarily deployed to preview September 6, 2023 09:34 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

✔️ Preview deployment uninstalled

Helm release appuio-control-api-preview/portal-pr-555
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use "Display Name" as dominant visual/title element
3 participants