Fix log messages for Zone K8s version controller #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use the default formatting for `version.Info` when we only set a limited amount of fields. Instead we introduce a thin wrapper for the `fmt.Sprintf()` which we already used to set the version on the control-api zone object and use that wrapper for the log messages.
bastjan
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We can't use the default formatting for
version.Infowhen we only set a limited amount of fields. Instead we introduce a thin wrapper for thefmt.Sprintf()which we already used to set the version on the control-api zone object and use that wrapper for the log messages.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog