Tweak "producer as parent" config option #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
force-pushed
the
tweak-producer-as-parent-config-option
branch
from
0408eed
to
9393e9f
Compare
Some tweaks to the changes introduced in #11. Rename the config option to `useProducerSpanAsConsumerParent` (that is, `s/Context/Span`) to use language that is more familiar to casual OpenTelemetry users. Rewrite the config option description to describe what happens with and without the config option. Rearrange the instrumentation to move logic branches out of the span creation function.
unflxw
force-pushed
the
tweak-producer-as-parent-config-option
branch
from
9393e9f
to
5d7ee27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor tweaks to the changes introduced in #11. See #10 for context.
Rename the config option to
useProducerSpanAsConsumerParent(that is,s/Context/Span) to use language that is more familiar to casual OpenTelemetry users.Rewrite the config option description to describe what happens with and without the config option.
Rearrange the instrumentation to move logic branches out of the span creation function.
[ping @Steffen911, in case you're using a pre-release version, note the config option name has been changed!]