narrowdown issue ignored NoExecuteInSqlPrepare statement for alter ad…

…d constraints #8
appsfortableau · May 25, 2022 · 640908d · 640908d
1 parent ccbdc86
commit 640908d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Contracts/OdbcDriver.php b/src/Contracts/OdbcDriver.php
@@ -3,7 +3,6 @@
 namespace LaravelPdoOdbc\Contracts;
 
 use Closure;
-use LaravelPdoOdbc\ODBCConnector;
 
 interface OdbcDriver
 {

diff --git a/src/Flavours/Snowflake/PDO/Statement.php b/src/Flavours/Snowflake/PDO/Statement.php
@@ -77,8 +77,8 @@ protected function _prepareValues(): array
 
     public function execute($bound_input_params = null)
     {
-        // TODO: quick fix for broken ODBC connection..  please make sure odbc config -> NoExecuteInSqlPrepare=false
-        if (count($this->bindings) === 0) {
+        // TEMP: all adding constraints queries are failing, current workaround.
+        if (str_contains($this->queryString, 'add constraint')) {
             return true;
         }
 

diff --git a/src/ODBCConnector.php b/src/ODBCConnector.php
@@ -66,9 +66,10 @@ public static function registerDriver(): Closure
     protected function buildDsnDynamicly(array $config): string
     {
         // ignore some default props...
-        $ignoreProps = ['driver', 'odbc_driver', 'dsn', 'options', 'username', 'password'];
+        $ignoreProps = ['driver', 'odbc_driver', 'dsn', 'options', 'server', 'username', 'password'];
         $props = Arr::except($config, $ignoreProps);
 
+
         if ($this->dsnIncludeDriver) {
             $props = ['driver' => Arr::get($config, 'odbc_driver')] + $props;
         }