This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Set hostNetwork to true, add documentation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests sets the AppOptics DaemonSet to use host networking instead of the overlay networking. If there are issues with the overlay network (say, Calico or Flannel), this enables the AppOptics agent to continue reporting instead of being down.
This also sets a DNS policy on the deployment manifest so that DNS resolution for the Kubernetes API server still works on the host network.
It'd be nice if, separately, we could still somehow get overlay network stats (maybe via an agent level change) as well but I believe when people (speaking for myself here) install the agent, what they expect are host network traffic stats by default. They could theoretically still get both by installing a second DaemonSet with hostNetwork set to false. I've also added this to the README for documentation.