Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sendability annotations on SocketOptionProvider #3034

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Lukasa
Copy link
Contributor

@Lukasa Lukasa commented Dec 18, 2024

Motivation:

SocketOptionProvider is used to apply a number of socket options. As part of using it in NIOPosix, it became apparent that several necessary sendability annotations are missing. Let's add those.

Modifications:

  • Add Sendable constraints with @preconcurrency to SocketOptionProvider.
  • Update the BaseSocketChannel conformance to match

Result:

Tighter Sendable constraints on SocketOptionProvider.

@Lukasa Lukasa added the 🆕 semver/minor Adds new public API. label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants