Enable MemberImportVisibility check - attempt 2 #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
enable_MemberImportVisibility_check_2
branch
3 times, most recently
from
010d5dc to
0277250
Compare
Enable MemberImportVisibility check on all targets. Use a standard string header and footer to bracket the new block for ease of updating in the future with scripts.
rnro
force-pushed
the
enable_MemberImportVisibility_check_2
branch
from
0277250 to
1afd8b5
Compare
rnro
commented
Dec 16, 2024
Comment on lines
27
to
32
| #if canImport(Darwin) | ||
| private let S_IFREG = Darwin.S_IFREG | ||
| #elseif canImport(Glibc) | ||
| private let S_IFREG = Glibc.S_IFREG | ||
| #endif | ||
|
|
There was a problem hiding this comment.
This block is probably worth calling out to reviewers
There was a problem hiding this comment.
Thanks, I built this patch natively on Android without a problem, so no changes needed there.
There was a problem hiding this comment.
I think we'll need the same for Musl as we check in a bunch of other places too.
There was a problem hiding this comment.
I think we'll need the same for Musl
Tough to say, as the static Musl SDK doesn't let you build the tests, swiftlang/swift-docker#396.
glbrntt
reviewed
Dec 17, 2024
Comment on lines
27
to
32
| #if canImport(Darwin) | ||
| private let S_IFREG = Darwin.S_IFREG | ||
| #elseif canImport(Glibc) | ||
| private let S_IFREG = Glibc.S_IFREG | ||
| #endif | ||
|
|
There was a problem hiding this comment.
I think we'll need the same for Musl as we check in a bunch of other places too.
glbrntt
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable MemberImportVisibility check on all targets. Use a standard string header and footer to bracket the new block for ease of updating in the future with scripts.
See #3021