Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bogus "unleakable promise leaked" error message (#2855) #3027

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix bogus "unleakable promise leaked" error message (#2855) #3027

merged 1 commit into from
Dec 16, 2024

Conversation

weissi
Copy link
Member

@weissi weissi commented Dec 15, 2024

Motivation:

SwiftNIO contained a bogus error message:

BUG in SwiftNIO (please report), unleakable promise leaked.:486: Fatal error: leaking promise created at (file: "BUG in SwiftNIO (please report), unleakable promise leaked.", line: 486)

The actual meaning is that the ELG was shut down prematurely.

Modifications:

  • Replace the message with an accurate one

Result:

@weissi weissi requested a review from Lukasa December 15, 2024 18:02
@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Dec 16, 2024
@Lukasa Lukasa merged commit ecfaa2c into apple:main Dec 16, 2024
33 of 36 checks passed
@weissi weissi deleted the jw-2855 branch December 16, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
2 participants
@weissi @Lukasa