Update metadata formatting for readability #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: For packages that generate logs and use them as part of the development process, it is beneficial to be able to read through logs without having to write custom log handlers or pull in a dependency for formatting only at dev time. Modifications: - Change: The format of `StreamLogHandler` to output metadata on newlines with tab indentation Result: Package authors will have an easier time debugging their applications without boilerplate code or dependencies. This resolves #162
|
Can one of the admins verify this patch? |
5 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@swift-server-bot add to whitelist |
|
Moved to: #162 to keep the general discussion in one place. |
|
Sure, I'll move my comment |
|
Following the discussion in the issue #162 I'm sorry but we won't be accepting such human-readable improvements into swift-log itself. Let's work on a separate package that can handle this though, happy to help! |
|
Understandable! No hurt feelings here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
For packages that generate logs and use them as part of the development process,
it is beneficial to be able to read through logs without having to write custom
log handlers or pull in a dependency for formatting only at dev time.
Modifications:
StreamLogHandlerto output metadata on newlines with tab indentationResult:
Package authors will have an easier time debugging their applications without boilerplate code or dependencies.
This resolves #162