[CI] Make all CI checks green #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-gha-fix
branch
6 times, most recently
from
f46277f to
f49110f
Compare
guoye-zhang
reviewed
Oct 23, 2024
guoye-zhang
approved these changes
Oct 23, 2024
FranzBusch
force-pushed
the
fb-gha-fix
branch
from
084bfb0 to
29c370b
Compare
# Motivation We just adopted GH actions and want to make sure all the CI checks are green. # Modification This PR makes the necessary changes to pass all checks. Including: - Adding a licenseignore file - Moving `swift-format` and adopting the config that we use in all other swift on server repos. # Result Green CI.
FranzBusch
force-pushed
the
fb-gha-fix
branch
from
29c370b to
700f199
Compare
This reverts commit 310e8ea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We just adopted GH actions and want to make sure all the CI checks are green.
Modification
This PR makes the necessary changes to pass all checks. Including:
swift-formatand adopting the config that we use in all other swift on server repos.Result
Green CI.