Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new Android overlay, swiftlang/swift#74758 #286

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add support for new Android overlay, swiftlang/swift#74758 #286

merged 1 commit into from
Oct 21, 2024

Conversation

finagolfin
Copy link
Contributor

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

I don't know why these imports are required only for the Android overlay and not other platforms, but I needed this patch for my Android CI.

Lukasa
Lukasa approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both very strange, thanks @finagolfin.

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Oct 21, 2024
@Lukasa Lukasa enabled auto-merge (squash) October 21, 2024 15:26
@Lukasa Lukasa merged commit 8fa345c into apple:main Oct 21, 2024
26 checks passed
@finagolfin finagolfin deleted the droid branch October 25, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finagolfin @Lukasa