Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ML-DSA post-quantum signatures to
_CryptoExtras
#267base: main
Are you sure you want to change the base?
Add ML-DSA post-quantum signatures to
_CryptoExtras
#267Changes from 29 commits
b42638c
ef1c321
e7015bc
dad4590
f595a7d
58351d1
dee0c3d
9d417d4
d5650a1
a5075ff
891b5a1
b856f48
8569b02
e85aa8e
114339f
d39ef72
b3c8328
4e29fb1
0334c64
36b37cc
530d87f
a7049c3
acd486a
5950937
e34c7e3
b0dc44b
e3776c2
b6494ff
545f5e7
aff3763
06154e4
0ac196b
654953e
4834aa5
ffe2688
b0839bc
aae10bf
c820d7a
0213029
7f4a578
9b1b317
e61fe0b
c879a71
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want
module
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it just to complete the ML-DSA acronym, maybe I could add an hyphen between it and
lattice
to make it clearer, as in the FIPS titleThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need an
unsafeTemporaryAllocation
. We can just zero-initialize the valueself.key = .init()
and then take a pointer to it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I also tried to remove the seed's
unsafeTemporaryAllocation
by passing to the BoringSSL function an empty[UInt8]
var and then initializing theData
object from it, but I encountered some seg faults in testing