-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include armv7 symbols in boringssl vendoring #228
base: main
Are you sure you want to change the base?
Include armv7 symbols in boringssl vendoring #228
Conversation
Sorry for letting this languish! @shahmishal is there any way we can get armv7 Swift images upstream? |
Any news on this? It would be nice to finish this up in one way or another. Let me know if there’s anything I can do! |
Maybe we just need to generate a Swift 6.0.1 unofficial container for armv7 now? Well, there are a couple of blockers to generating an SDK as was suggested previously:
However, if we can just use some of the existing swift-armv7 scripts to build Swift 6.0.1 and generate a container, would that be enough to at least get this done? It would be simple enough to update what we have working and generate something that could be used. |
Well, we have a working solution here, so unless there is any indication that this solution is not acceptable, I don’t think we need to do anything else. Regarding the Swift version. This provides 5.10 for armv7, while the other architectures are still on 5.9, so I think that’s fine for now. |
Yeah, I don't foresee an issue with the Swift version. If you can bring this up to current |
34a7d45
to
7a349c1
Compare
@Lukasa : I rebased this on main. Some notes:
|
@Lukasa any idea when you can review this? |
Updates the BoringSSL vendoring to include armv7 specific symbols.
I had to do a work-around that specifically checks out the version of BoringSSL that is currently used. This was necessary due to that the very latest on their main branch doesn't work properly with the current vendoring script. I suggest to not merge this until the vendoring script is updated to work with the latest BoringSSL version again, then the work-around can be removed.
The armv7 build is done using the following container: orobio/swift-armv7-cross-bullseye:5.10
It was created from orobio/swift-armv7.
This container is hosted on my DockerHub account. Would that be acceptable, or would you prefer to host it yourself?
Most of this is new territory for me, so feel free to mention anything that can be improved.